Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for selectors & actions moved to block-editor #15424

Merged
merged 5 commits into from
May 3, 2019

Conversation

oandregal
Copy link
Member

In #13088 we moved some actions and selectors to the block-editor package. This had the secondary effect of removing them from the handbook docs.

They'll be brought back to the handbook in #15421 but to avoid an immense PR difficult to review I'd like to merge this change first.

Test

Check that there are no changes in documentation just yet.

npm run docs:build

oandregal added 4 commits May 3, 2019 19:08
This is to avoid adding any symbols to the generated handbook docs just yet.
We'll add them back when switching to the new system.
export const resetBlocks = getBlockEditorAction( 'resetBlocks' );
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look great but from a code standards/ bike sheddy perspective I just wonder if we should have newlines above all these, similar to how it'd be done in PHP doc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do that d1b7aff

@oandregal oandregal requested a review from chrisvanpatten May 3, 2019 18:52
@oandregal oandregal merged commit b371259 into master May 3, 2019
@youknowriad youknowriad deleted the update/docs-editor-selectors-actions branch May 6, 2019 13:59
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants