Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with column block being selected. #14876

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Fix regression with column block being selected. #14876

merged 2 commits into from
Apr 11, 2019

Commits on Apr 9, 2019

  1. Fix regression with column block being selected. 

    The columns block is currently slightly fiddly, due to the nesting nature of Columns > Column > Blocks structure. All three levels are "Blocks" in the block editor sense, and all can be selected. This is pending enhancements in #9628.

However in the mean time, we have a hack in place, this uses `pointer-events` to prevent the _mouse_ selection of the individual column blocks. This makes it drastically simpler to select the Columns block, which is where you can adjust the number of columns in the block. The individual column blocks, on the other hand, is currently largely inactionable. You can set alignments on them, which is why #9628 is urgent, but until we have a better system for selecting parent blocks, this pointer-events hack is arguably the better stopgap solution.

That hack regressed in master. This PR restores it, and makes it slightly better.

Things to test:

- Insert a columns block with content, and verify you can select both child and parent block.
- Insert an "Archives" block inside a column, and verify that the block itself is clickable, but the links inside are not (it's using component-disabled to make archive links unfollowable)
    Joen Asmussen committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    593089a View commit details
    Browse the repository at this point in the history

  2. Fix mess ¯\_(ツ)_/¯

    Joen Asmussen committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    118fbfe View commit details
    Browse the repository at this point in the history