Mobile: Fix links ui on landscape iOS #14047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RichText: only ignore input types that insert HTML * Mark RichTextInputEvent as unstable * Use Set
…eters returned onChange, and we forgot to update the PostTitle component (#13967)
Upload media progress bar is missing while media is uploading new
* Trigger onFocusStatusChange from PostTitle * Fix lint issue * Update post title shadow mechanism Also open inner ref so that focus state can be updated when focus is made programmatically * Update props * Update onRef as ref * Update title padding&margin
* Changed upload media icon color * Changed media placeholder background color
* Fix unexpected token in native code * Dummy commit to trigger Travis * Include the rnmobile release branch to Travis builds
* Mobile: Replaced Links UI with bottom-sheet component * Mobile links UI: Removed commented code. * Mobile: Fix lint issues * Mobile Links UI: Remove autofocus on Android. This hides an issue where the modal sometimes will be under the keyboard on Android.
etoledom
added
the
Mobile App - i.e. Android or iOS
etoledom
requested review from
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
|
hey @etoledom 👋 is it possible that you commit the original version of the Facebook’s KeyboardAvoidingView and then commit your changes separately so that I can understand which part you changed? |
etoledom
requested review from
nerrad,
oandregal,
notnownikki,
ntwb,
Soean and
swissspidy
as code owners
This reverts commit 170fc9d.
etoledom
removed request for
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
dmsnell,
jorgefilipecosta,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
oandregal,
notnownikki,
ntwb,
Soean and
swissspidy
|
Closing in favor of #14240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilereference: wordpress-mobile/gutenberg-mobile#647Description
This PR fixes an issue on KeyboardAvoidingView, that was adding extra bottom padding on specific circumstances:
With some debugging I noticed a problem on the way the extra padding is calculated, so I made a simplified version of the component that will work well on the BottomSheet.
Note: The BottomSheet is not scrollable (yet).
To test: