Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: BottomSheet design tweaks v2 #13855

Merged
merged 21 commits into from
Feb 18, 2019
Merged

Mobile: BottomSheet design tweaks v2 #13855

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6bbec03
Mobile BottomSheet: Added the posibility of selecting the cell separ…
etoledom Feb 13, 2019
2ba4502
Mobile BottomSheet: Increased space between top and table
etoledom Feb 13, 2019
f01c5eb
Mobile BottomSheet: Truncating long values at the middle of the string.
etoledom Feb 13, 2019
1ab8564
Fix lint issues
etoledom Feb 13, 2019
dd79208
Merge branch 'master' into rnmobile/bottom-sheet-design-v2
etoledom Feb 13, 2019
ee642e9
Fix syntax error to pass CI
etoledom Feb 13, 2019
2ddcf01
Merge branch 'rnmobile/bottom-sheet-design-v2' of https://github.com/…
etoledom Feb 13, 2019
99a7494
Fix lint issue
etoledom Feb 13, 2019
2a680d2
Merge branch 'master' into rnmobile/bottom-sheet-design-v2
etoledom Feb 15, 2019
12883cc
Mobile Picker: Tweak Android styles.
etoledom Feb 15, 2019
440ab55
Mobile BottomSheet: Simplified Android cell styling.
etoledom Feb 15, 2019
0f0836f
Mobile: Fix swipe to dismiss on BottomSheet
etoledom Feb 15, 2019
de982ba
Fix lint issues
etoledom Feb 15, 2019
984e7c1
Mobile BottomSheet: Fixes sensibility of pan vs tap gestures on swipe…
etoledom Feb 15, 2019
a9e115d
Fix lint issues
etoledom Feb 15, 2019
33b07c5
Merge branch 'master' into rnmobile/bottom-sheet-design-v2
marecar3 Feb 15, 2019
a92dce5
Fixed failed tests
marecar3 Feb 15, 2019
9b94dbe
Mobile BottomSheet cell: Removed unnecessary variable init.
etoledom Feb 18, 2019
787df73
Fixed set state after component is unmounted
marecar3 Feb 18, 2019
e1ac44a
Revert "Fixed set state after component is unmounted"
marecar3 Feb 18, 2019
d78102a
Merge branch 'master' into rnmobile/bottom-sheet-design-v2
marecar3 Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix syntax error to pass CI
  • Loading branch information
@etoledom
etoledom committed Feb 13, 2019
commit ee642e94db7ea432276b53bdea87e081c91b2e70
11 changes: 7 additions & 4 deletions packages/editor/src/components/mobile/bottom-sheet/cell.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@ import { Component } from '@wordpress/element';
import styles from './styles.scss';

export default class Cell extends Component {
state = {
isEditingValue: false,
}

_valueTextInput = undefined;

constructor() {
super( ...arguments );
this.state = {
isEditingValue: false,
};
}

componentDidUpdate() {
if ( this.state.isEditingValue ) {
this._valueTextInput.focus();
Expand Down