add tests for new code

- also removes old code that’s been replaced and fixes up imports

packages/editor/src/store/actions.js

@@ -44,9 +44,52 @@ export function resetPost( post ) {
 
 /**
  * Returns an action object used in signalling that the latest autosave of the
- * post has been received, by initialization or autosave.
+ * specified client ID has been selected, optionally accepting a position
+ * value reflecting its selection directionality. An initialPosition of -1
+ * reflects a reverse selection.
  *
- * @param {Object} post Autosave post object.
+ * @param {string}  clientId        Block client ID.
+ * @param {?number} initialPosition Optional initial position. Pass as -1 to
+ *                                  reflect reverse selection.
+ *
+ * @return {Object} Action object.
+ */
+export function selectBlock( clientId, initialPosition = null ) {
+	return {
+		type: 'SELECT_BLOCK',
+		initialPosition,
+		clientId,
+	};
+}
+
+export function startMultiSelect() {
+	return {
+		type: 'START_MULTI_SELECT',
+	};
+}
+
+export function stopMultiSelect() {
+	return {
+		type: 'STOP_MULTI_SELECT',
+	};
+}
+
+export function multiSelect( start, end ) {
+	return {
+		type: 'MULTI_SELECT',
+		start,
+		end,
+	};
+}
+
+export function clearSelectedBlock() {
+	return {
+		type: 'CLEAR_SELECTED_BLOCK',
+	};
+}
+
+/**
+ * Returns an action object that enables or disables block selection.
  *
  * @return {Object} Action object.
  */
@@ -125,8 +168,6 @@ export function refreshPost() {
 export function trashPost( postId, postType ) {
 	return {
 		type: 'TRASH_POST',
-		postId,
-		postType,
 	};
 }
 

packages/editor/src/store/actions/index.js

@@ -0,0 +1,2 @@
+export * from './post-actions';
+export * from './post-generators';

packages/editor/src/store/actions/post-actions.js

@@ -9,12 +9,42 @@ import { BEGIN, COMMIT, REVERT } from 'redux-optimist';
 import { POST_UPDATE_TRANSACTION_ID } from '../constants';
 
 /**
- * Optimistic action for requesting post update start.
+ * Returns an action object used in signalling that the latest version of the
+ * post has been received, either by initialization or save.
+ *
+ * @param {Object} post Post object.
+ *
+ * @return {Object} Action object.
+ */
+export function resetPost( post ) {
+	return {
+		type: 'RESET_POST',
+		post,
+	};
+}
+
+/**
+ * Returns an action object used in signalling that the latest autosave of the
+ * post has been received, by initialization or autosave.
+ *
+ * @param {Object} post Autosave post object.
+ *
+ * @return {Object} Action object.
+ */
+export function resetAutosave( post ) {
+	return {
+		type: 'RESET_AUTOSAVE',
+		post,
+	};
+}
+
+/**
+ * Optimistic action for dispatching that a post update request has started.
  *
  * @param {Object} options
  * @return {Object} An action object
  */
-export function requestPostUpdateStart( options = {} ) {
+export function __experimentalRequestPostUpdateStart( options = {} ) {
 	return {
 		type: 'REQUEST_POST_UPDATE_START',
 		optimist: { type: BEGIN, id: POST_UPDATE_TRANSACTION_ID },
@@ -23,7 +53,8 @@ export function requestPostUpdateStart( options = {} ) {
 }
 
 /**
- * Optimistic action for requesting post update success.
+ * Optimistic action for indicating that the request post update has completed
+ * successfully.
  *
  * @param {Object} previousPost The previous post prior to update.
  * @param {Object} post	The new post after update
@@ -33,7 +64,7 @@ export function requestPostUpdateStart( options = {} ) {
  * @param {Object} postType The post type object.
  * @return {Object} Action object.
  */
-export function requestPostUpdateSuccess( {
+export function __experimentalRequestPostUpdateSuccess( {
 	previousPost,
 	post,
 	isRevision,
@@ -58,7 +89,8 @@ export function requestPostUpdateSuccess( {
 }
 
 /**
- * Optimistic action for requesting post update failure.
+ * Optimistic action for indicating that the request post update has completed
+ * with a failure.
  *
  * @param {Object} post The post that failed updating.
  * @param {Object} edits The fields that were being updated.
@@ -67,7 +99,7 @@ export function requestPostUpdateSuccess( {
  * dispatch.
  * @return {Object} An action object
  */
-export function requestPostUpdateFailure( {
+export function __experimentalRequestPostUpdateFailure( {
 	post,
 	edits,
 	error,
@@ -98,16 +130,59 @@ export function updatePost( edits ) {
 	};
 }
 
+/**
+ * Returns an action object used in signalling that attributes of the post have
+ * been edited.
+ *
+ * @param {Object} edits Post attributes to edit.
+ *
+ * @return {Object} Action object.
+ */
+export function editPost( edits ) {
+	return {
+		type: 'EDIT_POST',
+		edits,
+	};
+}
+
 /**
  * Returns action object produced by the updatePost creator augmented by
  * an optimist option that signals optimistically applying updates.
  *
  * @param {Object} edits  Updated post fields.
  * @return {Object} Action object.
  */
-export function optimisticUpdatePost( edits ) {
+export function __experimentalOptimisticUpdatePost( edits ) {
 	return {
 		...updatePost( edits ),
 		optimist: { id: POST_UPDATE_TRANSACTION_ID },
 	};
 }
+
+/**
+ * Returns an action object used to signal that post saving is locked.
+ *
+ * @param  {string} lockName The lock name.
+ *
+ * @return {Object} Action object
+ */
+export function lockPostSaving( lockName ) {
+	return {
+		type: 'LOCK_POST_SAVING',
+		lockName,
+	};
+}
+
+/**
+ * Returns an action object used to signal that post saving is unlocked.
+ *
+ * @param  {string} lockName The lock name.
+ *
+ * @return {Object} Action object
+ */
+export function unlockPostSaving( lockName ) {
+	return {
+		type: 'UNLOCK_POST_SAVING',
+		lockName,
+	};
+}

packages/editor/src/store/actions/post-generators.js

@@ -90,7 +90,7 @@ export function* savePost( options = {} ) {
 
 	yield dispatch(
 		MODULE_KEY,
-		'requestPostUpdateStart',
+		'__experimentalRequestPostUpdateStart',
 		options,
 	);
 
@@ -99,7 +99,7 @@ export function* savePost( options = {} ) {
 	// if the autosave is applied as a revision.
 	yield dispatch(
 		MODULE_KEY,
-		'optimisticUpdatePost',
+		'__experimentalOptimisticUpdatePost',
 		toSend
 	);
 
@@ -142,7 +142,7 @@ export function* savePost( options = {} ) {
 
 		yield dispatch(
 			MODULE_KEY,
-			'requestPostUpdateSuccess',
+			'__experimentalRequestPostUpdateSuccess',
 			{
 				previousPost: post,
 				post: newPost,
@@ -159,6 +159,7 @@ export function* savePost( options = {} ) {
 			previousPost: post,
 			post: newPost,
 			postType,
+			options,
 		} );
 		if ( notifySuccessArgs.length > 0 ) {
 			yield dispatch(
@@ -170,7 +171,7 @@ export function* savePost( options = {} ) {
 	} catch ( error ) {
 		yield dispatch(
 			MODULE_KEY,
-			'requestPostUpdateFailure',
+			'__experimentalRequestPostUpdateFailure',
 			{ post, edits, error, options }
 		);
 		const notifyFailArgs = getNotificationArgumentsForSaveFail( {
@@ -188,6 +189,15 @@ export function* savePost( options = {} ) {
 	}
 }
 
+/**
+ * Action generator used in signalling that the post should autosave.
+ *
+ * @param {Object?} options Extra flags to identify the autosave.
+ */
+export function* autosave( options ) {
+	yield* actions.savePost( { isAutosave: true, ...options } );
+}
+
 /**
  * Action generator for trashing the current post in the editor.
  */
@@ -218,8 +228,8 @@ export function* trashPost() {
 			}
 		);
 
-		// TODO: This should be an updatePost action (updating subsets of post properties),
-		// But right now editPost is tied with change detection.
+		// TODO: This should be an updatePost action (updating subsets of post
+		// properties), but right now editPost is tied with change detection.
 		yield dispatch(
 			MODULE_KEY,
 			'resetPost',
@@ -229,7 +239,7 @@ export function* trashPost() {
 		yield dispatch(
 			'core/notices',
 			'createErrorNotice',
-			getNotificationArgumentsForTrashFail( { error } ),
+			...getNotificationArgumentsForTrashFail( { error } ),
 		);
 	}
 }
@@ -264,3 +274,12 @@ export function* refreshPost() {
 		newPost
 	);
 }
+
+const actions = {
+	savePost,
+	autosave,
+	trashPost,
+	refreshPost,
+};
+
+export default actions;