Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onCaretVerticalPositionChange event #13323

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Add onCaretVerticalPositionChange event #13323

merged 1 commit into from
Jan 17, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Jan 15, 2019 •
edited
Loading

Description

This PR adds onCaretVerticalPositionChange event to fix wordpress-mobile/gutenberg-mobile#464

How has this been tested?

Tested with steps on gutenberg-mobile PR

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@pinarol pinarol added the [Status] In Progress Tracking issues with work in progress label Jan 15, 2019
@pinarol pinarol self-assigned this Jan 15, 2019
@pinarol pinarol mentioned this pull request Jan 15, 2019
Merged
@pinarol pinarol requested a review from etoledom January 15, 2019 12:50
etoledom
etoledom approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via wordpress-mobile/gutenberg-mobile#474 (review)

✅

@pinarol pinarol merged commit df2fad3 into master Jan 17, 2019
@pinarol pinarol deleted the rnmobile/add-caret-vertical-position-change branch January 17, 2019 17:33
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed [Status] In Progress Tracking issues with work in progress labels Jan 22, 2019
@gziolo gziolo added this to the 4.9 (Gutenberg) milestone Jan 22, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@pinarol @youknowriad
Add onCaretVerticalPositionChange event (#13323)
8266a56
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@pinarol @youknowriad
Add onCaretVerticalPositionChange event (#13323)
cbe5279
@hypest hypest mentioned this pull request Oct 25, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@pinarol pinarol

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
4.9 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

iOS - There is no autoscroll to follow the cursor when the content goes behind the toolbar
3 participants
@pinarol @etoledom @gziolo