Fix: Missing margin in blocks with child blocks #13227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
jasmussen
approved these changes
Jan 8, 2019
jorgefilipecosta
force-pushed
the
fix/add-margin-to-blocks-with-child-blocks
branch
from
19644d2
to
2fe7878
Compare
|
Thank you for the review @jasmussen. |
|
I think that's good! Ship it. |
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #13010
A margin was missing for the parent block on the inserter child blocks area.
This PR just adds a small margin.
How has this been tested?
I added the test block available in https://gist.github.com/jorgefilipecosta/60a0bf242e8c7c18805618558268315d.
I inserted the parent block, I used the sibling inserter inside the parent block and I verified a small margin appears between the parent block icon and the block name.
Screenshots
Before:
After: