Skip: Adding inline tokens end 2 end test. #12464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Nov 30, 2018
| await newPost(); | ||
| } ); | ||
|
|
||
| it( 'should insert inline image', async () => { |
There was a problem hiding this comment.
Maybe we should just .skip it for the moment?
There was a problem hiding this comment.
Yes that a better option, the code was updated.
There was a problem hiding this comment.
@ntwb Looks like it's a permissions issue (the upload is failing), I don't know if you have any idea why it started happening suddenly.
For now I'm going to approve to unblock the other PRs.
There was a problem hiding this comment.
Can we add an explanation why it was skipped? We have already 3 skipped tests which we never unskipped and they are already invalid even though the issues were already fixed.
The file uploads are not working on travis, and our end 2 end tests are failing, we are skipping the test until we find a solution to this problem.
jorgefilipecosta
force-pushed
the
remove/end-2-end-test-inline-token-test
branch
from
e2cd4a0 to
29207dc
Compare
jorgefilipecosta
changed the title
youknowriad
approved these changes
Nov 30, 2018
gziolo
added
the
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file uploads are not working on Travis, and our end 2 end tests are failing, we are removing the test until we find a solution to this problem.
How has this been tested?
I verified end 2 end tests are passing.