Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing redundant currentColor CSS value #12329

Closed
wants to merge 4 commits into from
Closed

Removing redundant currentColor CSS value #12329

wants to merge 4 commits into from

Conversation

webmandesign
Copy link
Contributor

Fixes #12328

@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement. labels Feb 5, 2019
@gziolo gziolo requested review from jasmussen and kjellr February 5, 2019 15:15
@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Feb 5, 2019
@jasmussen
Copy link
Contributor

You're absolutely right, and this seems like an excellent PR. Thanks so much. Unless Kjell has objections, I think this PR just needs a rebase and then let's ship it! 👍 👍

@kjellr
Copy link
Contributor

kjellr commented Feb 6, 2019

Looks good to me too! Once those conflicts are sorted out this should be ready to 🚢. Thank you!

@gziolo
Copy link
Member

gziolo commented Feb 13, 2019

@webmandesign would you mind bringing this branch up to date with the changes applied in master branch? This is blocking this PR to be included in the upcoming Gutenberg 5.1 release which is planned for early next week.

@webmandesign
Copy link
Contributor Author

Hi guys,

Thank you for feedback and sorry for delay in my answer. As I have a problem with rebase, I've decided to create a new pull request #14119 Please check there for my additional comments.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants