Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image assets for the plugin directory. #1208

Merged
merged 2 commits into from
Jun 16, 2017
Merged

Conversation

mtias
Copy link
Member

@mtias mtias commented Jun 16, 2017

banner-772x250

@mtias mtias added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jun 16, 2017
@jasmussen
Copy link
Contributor

We previously kept image assets out of this repository to not balloon revisions for all branches.

But these files are small, they aren't likely to change very often, and it makes many plugin creation aspects simpler, so I think this is a good exception. 👍

@mtias
Copy link
Member Author

mtias commented Jun 16, 2017

We may be able to place them in the github assets management pipeline, but I don't have experience with it.

@mtias mtias merged commit e3869f8 into master Jun 16, 2017
@mtias mtias deleted the add/plugin-image-assets branch June 16, 2017 09:05
codebykat added a commit that referenced this pull request Jun 17, 2017
@codebykat codebykat mentioned this pull request Jun 17, 2017
mtias pushed a commit that referenced this pull request Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants