Fix undefined variable warning in gutenberg.php #12053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Priority] High
youknowriad
reviewed
Nov 19, 2018
gutenberg.php
Outdated
| @@ -67,6 +67,7 @@ function the_gutenberg_project() { | |||
| * @since 0.1.0 | |||
| */ | |||
| function gutenberg_menu() { | |||
| global $post; | |||
| if ( ! gutenberg_can_edit_post( $post ) ) { | |||
There was a problem hiding this comment.
I think it doesn't make sense to keep the check actually because this menu is always rendered in the admin and not only when there's a global $post variable (post being edited).
I think the reasoning for the PR was to hide the menu if the rich-text preference is disabled But I don't think it's very important to check for it anyway.
There was a problem hiding this comment.
I pushed a commit to remove the check entirely.
4 tasks
Closed
youknowriad
force-pushed
the
fix/undefined-global-post
branch
from
47c0672 to
6ad33c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced an undefined global
$postvariable in 095d18f.Quick fix for that.
closes #12061