MediaUpload: Fix insesrting images with captions#10645
Closed
youknowriad wants to merge 1 commit intomasterfrom
Closed
MediaUpload: Fix insesrting images with captions#10645youknowriad wants to merge 1 commit intomasterfrom
youknowriad wants to merge 1 commit intomasterfrom
Conversation
youknowriad
added
[Type] Bug
Member
|
@youknowriad This is a duplicate of #10532. |
youknowriad
force-pushed
the
fix/media-upload
branch
from
d9f230d to
35d746a
Compare
Contributor
Author
|
Oh sorry, I missed it. I removed some other bits in TextColumns and File |
Member
|
Oh yes, file and text columns still need to be adjusted, thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10597
This PR removes all the specific "rich-text" format handling we were doing for media uploads. We just consider the caption of images as HTML strings.
This fixes inserting images with captions from the Media Library
Testing instructions