Skip to content

Quick tags buttons need to be properly labeled (regression from current editor) #979

Closed

Description

In the current WordPress text editor, the QuickTags buttons are properly labeled (the labels are also translatable):

screen shot 2017-06-01 at 18 31 47

In Gutenberg, they're not (yet?):

screen shot 2017-06-01 at 18 31 28

The current rendered markup is, for example:
<button class="editor-text-editor__bold">b</button>

All these buttons need aria-label attributes with translatable strings, as in the current text editor.
To evaluate: do they need also a type="button" attribute?

Aside: as mentioned in another issue, personally I'm not fully convinced QuickTags should stay but if they have to stay they should be accessible and not introduce accessibility regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    [Feature] Code EditorHandling the code view of the editing experience[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions