Skip to content

Poor spacing for NoticeActions in Notice component #69426

Open
@daledupreez

Description

@daledupreez

Description

The spacing between the main children of the Notice component and actions added to the Notice component via the noticeActions prop is too tight. Also, there is no vertical spacing between multiple notice actions, which is very noticeable on mobile.

Note that there should be space between the text and the actions as per the Notice layout in the WordPress Design System Figma here. The Figma doesn't capture a mobile viewport, but the buttons being so close together is a bad layout regardless.

Step-by-step reproduction instructions

These reproductions rely on Storybook as a way to exclude other CSS as much as possible.

Basic spacing between children and actions

Vertical spacing between actions on mobile

Screenshots, screen recording, code snippet

Spacing when actions are present

Image

Spacing when actions are vertical

Image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Feature] UI ComponentsImpacts or related to the UI component system[Package] Components/packages/components[Status] In ProgressTracking issues with work in progress[Type] BugAn existing feature does not function as intended

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions