DataViews: Style destructive secondary actions

[doekenorg]

What problem does this address?

Actions can be made "destructive" by setting the isDestructive attribute to true. When viewing this as a primary action, this is apparent by the red color. These styles are not applied to a secondary destructive action.

What is your proposed solution?

Apply destructive styling on secondary actions, and provide a is-destructive class there as well, for any required customisation.

CC: @WordPress/gutenberg-components

[himanshupathak95]

Hey @doekenorg, Thanks for bringing this up!

I think this would be a great accessibility enhancement and I would like to help implement this feature.

Could you please help me with:

1. Steps to reproduce the current behavior
2. The WordPress and plugin versions you're using

Currently, I'm not able to replicate this exact behavior and having these details would help me get started.

Thanks in advance!

[doekenorg]

Hi @himanshupathak95,

You can reproduce this behaviour on the latest version. If you install the storybook locally, you can reproduce it on there.

After reading https://developer.wordpress.org/block-editor/contributors/code/getting-started-with-code-contribution/ you should be able to set it up locally. If you then run npm install && npm run storybook:dev you can use the https://github.com/WordPress/gutenberg/blob/trunk/packages/dataviews/src/components/dataviews/stories/index.story.tsx#L23 file to make changes and try it out.

[ntsekouras]

I think we had that at first and later removed.. 🤔

--cc @WordPress/gutenberg-design

[jameskoster]

I'd encourage us to hold on any changes here, and await the outcome of #58390 which seeks to define when to use destructive styling at a higher level.