Skip to content

Deprecate ButtonGroup component #65338

Open

Description

What problem does this address?

The component does two things:

As we can see from the usages in the Gutenberg app, role="group" is not semantically sufficient to make these buttons behave like a segmented control, and most consumers will not realize this. As such, most of our in-repo usages are inaccessible.

The outdated segmented control style is similar to the already deprecated RadioGroup, and is succeeded by the ToggleGroupControl style.

What is your proposed solution?

Consumers who want to wrap their buttons in a group can do that with a plain <div role="group">.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    [Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Changes that impact accessibility and need corresponding review (e.g. markup changes).[Package] Components/packages/components/packages/components[Type] Code QualityIssues or PRs that relate to code qualityIssues or PRs that relate to code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions