Skip to content

Image and Media & Text blocks: Use LinkControl #50893

Open

Description

Part of #50891

As part of the effort to consolidate the link application experience across the editor #50891, let's use LinkControl to apply links to the core/image and core/media-text blocks as well. It may be useful to have LinkControl depict what controls render when in a media context (like these two blocks).

Tasks

  • Implement LinkControl within the Image block.
  • Implement LinkControl within the Media & Text block.
  • Add a method for LinkControl to render media-specific actions at the foot (above "Add new page").
  • Do not render "Text" input field when in media-specific context.
  • Add support for "Class" input field in the link settings drawer when in media-specific context (supporting existing feature-set).

Visual

Current Proposed
CleanShot 2023-05-23 at 15 34 14 CleanShot 2023-05-23 at 15 33 55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Needs DevReady for, and needs developer efforts[Block] ImageAffects the Image Block[Block] Media & TextAffects the Media & Text Block[Feature] Link EditingLink components (LinkControl, URLInput) and integrations (RichText link formatting)[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).[Type] EnhancementA suggestion for improvement.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions