Open
Description
openedon Feb 9, 2023
With the merge of #24914 the exhaustive deps eslint rule is now active in "warning" mode.
We need to work towards removing those warnings in order that we can switch the setting to "error" in future.
The strategy for doing this is outline by @ciampo below:
For the strategy towards "zero warnings", I suggest the approach that we took for the components package:
- focus on one package at a time
- remove all warnings, either by satisfying eslint demants, or by ignoring them when a rewrite would be complicated (while also adding a code comment explaining the reason for the disable)
- once all warnings are gone, change the rule for that specific package from
warn
toerror
to avoid re-introducing more errors - pick a new package, repeat
Originally posted by @ciampo in #24914 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
/packages/eslint-plugin/packages/eslint-pluginIssues or PRs that relate to code qualityIssues or PRs that relate to code quality