Skip to content

Inserter menu ARIA roles and attributes #3617

Closed
@afercia

Description

Splitting this out from #1823

The inserter is now in a stable enough state but still uses ARIA roles and attributes that where added in a first implementation, when the block types were presented in a sort of vertical list.

Testing with screen readers, it appears there's the need to make some adjustments. I think the roles menu and menuitem can stay, but there's probably the need to "flatten" the ARIA tree and use some role="presentation" on other elements. This would require some testing.

Nooticed so far:

  • JAWS 2018 and IE11 don't announce the name of the block types. They announce just "menu"
  • Firefox and NVDA incorrectly report the number of items in a category group (right now, each group is an ARIA menu), see screenshots below

Seems there's no consistency in the (wrong) number of items that gets announced:

in this case, there are 3 items but then NVDA announces "n of 4"

screenshot 13

and in this case, there are 3 items but then NVDA announces "n of 7"

screenshot 14

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    [Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions