Skip to content

Commit

Permalink
Fix Blocker Picker autocompleter icon spacing (#14772)
Browse files Browse the repository at this point in the history
* Fixes classname to match package and CSS rule

During the creation of block-editor the className on the autocompleter wasn’t updated. This change updates the class to use the `block-editor-` prefix. This causes the CSS to apply again thereby correcting the margin that was missing.

* Revert "Fixes classname to match package and CSS rule"

This reverts commit 28eb706.

* Editor: Revert autocompleters classnames to editor prefix

Co-Authored-By: Daniel Richards <talldan@users.noreply.github.com>
  • Loading branch information
2 people authored and aduth committed Apr 16, 2019
1 parent 4bd4280 commit d1f5c41
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions packages/editor/src/components/autocompleters/style.scss
Original file line number Diff line number Diff line change
@@ -1,28 +1,27 @@

.block-editor-autocompleters__block {
.block-editor-block-icon {
.editor-autocompleters__block {
.editor-block-icon {
margin-right: 8px;
}
}

.block-editor-autocompleters__user {
.block-editor-autocompleters__user-avatar {
.editor-autocompleters__user {
.editor-autocompleters__user-avatar {
margin-right: 8px;
flex-grow: 0;
flex-shrink: 0;
max-width: none; // we must override the gutenberg default of 100%
width: 24px; // avoid jarring resize by seting the size upfront
height: 24px;
}
.block-editor-autocompleters__user-name {
.editor-autocompleters__user-name {
white-space: nowrap;
text-overflow: ellipsis;
overflow: hidden;
max-width: 200px;
flex-shrink: 0;
flex-grow: 1;
}
.block-editor-autocompleters__user-slug {
.editor-autocompleters__user-slug {
margin-left: 8px;
color: $dark-gray-100;
white-space: nowrap;
Expand All @@ -32,7 +31,7 @@
flex-grow: 0;
flex-shrink: 0;
}
&:hover .block-editor-autocompleters__user-slug {
&:hover .editor-autocompleters__user-slug {
color: $blue-medium-300;
}
}

0 comments on commit d1f5c41

Please sign in to comment.