Skip to content

Commit

Permalink
[RNMobile] Prevent react-native-video crash that happens when an `s…
Browse files Browse the repository at this point in the history
…rc` changes quickly after first being set (#59841)

Unlinked contributors: crazytonyli.

Co-authored-by: SiobhyB <siobhyb@git.wordpress.org>
Co-authored-by: jhnstn <jsnjohnston@git.wordpress.org>
Co-authored-by: staskus <povilasstaskus@git.wordpress.org>
  • Loading branch information
4 people authored Mar 13, 2024
1 parent fde2dd5 commit b4017dc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/block-library/src/video/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,10 @@ class VideoEdit extends Component {
} ) => {
const showVideo =
isURL( src ) &&
getProtocol( attributes.src ) !== 'file:' &&
! isUploadInProgress &&
! isUploadFailed;

const icon = this.getIcon(
isUploadFailed
? ICON_TYPE.RETRY
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ For each user feature we should also add a importance categorization label to i
- [*] Gallery block items with in-progress, paused, or failed media uploads correctly display an highlight outline when selected [#59423]
- [**] [internal] Upgrade React Native to version 0.73.3 [#58475]
- [**] Add error boundary components and exception logging [#59221]
- [**] Fix crash occurring when the URL associated with a Video block is changed too quickly [#59841]

## 1.114.1
- [**] Fix a crash produced when the content of a synced pattern is updated [#59632]
Expand Down

0 comments on commit b4017dc

Please sign in to comment.