Add default value for disabled prop

WordPress · Dec 20, 2024 · a6d5fc1 · a6d5fc1
1 parent 6b15b98
commit a6d5fc1
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/packages/components/src/menu/checkbox-item.tsx b/packages/components/src/menu/checkbox-item.tsx
@@ -21,7 +21,7 @@ export const MenuCheckboxItem = forwardRef<
 	HTMLDivElement,
 	WordPressComponentProps< MenuCheckboxItemProps, 'div', false >
 >( function MenuCheckboxItem(
-	{ suffix, children, hideOnClick = false, ...props },
+	{ suffix, children, disabled = false, hideOnClick = false, ...props },
 	ref
 ) {
 	const menuContext = useContext( MenuContext );
@@ -37,6 +37,7 @@ export const MenuCheckboxItem = forwardRef<
 			ref={ ref }
 			{ ...props }
 			accessibleWhenDisabled
+			disabled={ disabled }
 			hideOnClick={ hideOnClick }
 			store={ menuContext.store }
 		>

diff --git a/packages/components/src/menu/item.tsx b/packages/components/src/menu/item.tsx
@@ -15,7 +15,15 @@ export const MenuItem = forwardRef<
 	HTMLDivElement,
 	WordPressComponentProps< MenuItemProps, 'div', false >
 >( function MenuItem(
-	{ prefix, suffix, children, hideOnClick = true, store, ...props },
+	{
+		prefix,
+		suffix,
+		children,
+		disabled = false,
+		hideOnClick = true,
+		store,
+		...props
+	},
 	ref
 ) {
 	const menuContext = useContext( MenuContext );
@@ -37,6 +45,7 @@ export const MenuItem = forwardRef<
 			ref={ ref }
 			{ ...props }
 			accessibleWhenDisabled
+			disabled={ disabled }
 			hideOnClick={ hideOnClick }
 			store={ computedStore }
 		>

diff --git a/packages/components/src/menu/radio-item.tsx b/packages/components/src/menu/radio-item.tsx
@@ -28,7 +28,7 @@ export const MenuRadioItem = forwardRef<
 	HTMLDivElement,
 	WordPressComponentProps< MenuRadioItemProps, 'div', false >
 >( function MenuRadioItem(
-	{ suffix, children, hideOnClick = false, ...props },
+	{ suffix, children, disabled = false, hideOnClick = false, ...props },
 	ref
 ) {
 	const menuContext = useContext( MenuContext );
@@ -44,6 +44,7 @@ export const MenuRadioItem = forwardRef<
 			ref={ ref }
 			{ ...props }
 			accessibleWhenDisabled
+			disabled={ disabled }
 			hideOnClick={ hideOnClick }
 			store={ menuContext.store }
 		>

diff --git a/packages/components/src/menu/types.ts b/packages/components/src/menu/types.ts
@@ -27,6 +27,7 @@ export interface MenuProps {
 	 *
 	 * Note: this prop will be overridden by the `open` prop if it is
 	 * provided (meaning the component will be used in "controlled" mode).
+	 *
 	 * @default false
 	 */
 	defaultOpen?: Ariakit.MenuProviderProps[ 'defaultOpen' ];
@@ -186,6 +187,8 @@ export interface MenuItemProps {
 	 * Determines if the element is disabled. This sets the `aria-disabled`
 	 * attribute accordingly, enabling support for all elements, including those
 	 * that don't support the native `disabled` attribute.
+	 *
+	 * @default false
 	 */
 	disabled?: Ariakit.MenuItemProps[ 'disabled' ];
 	/**
@@ -227,6 +230,8 @@ export interface MenuCheckboxItemProps {
 	 * Determines if the element is disabled. This sets the `aria-disabled`
 	 * attribute accordingly, enabling support for all elements, including those
 	 * that don't support the native `disabled` attribute.
+	 *
+	 * @default false
 	 */
 	disabled?: Ariakit.MenuItemCheckboxProps[ 'disabled' ];
 	/**
@@ -289,6 +294,8 @@ export interface MenuRadioItemProps {
 	 * Determines if the element is disabled. This sets the `aria-disabled`
 	 * attribute accordingly, enabling support for all elements, including those
 	 * that don't support the native `disabled` attribute.
+	 *
+	 * @default false
 	 */
 	disabled?: Ariakit.MenuItemRadioProps[ 'disabled' ];
 	/**