Address code review and avoid writing map files

WordPress · Aug 16, 2024 · a51dfd4 · a51dfd4
1 parent 3025382
commit a51dfd4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/client-assets.php b/lib/client-assets.php
@@ -238,11 +238,11 @@ function gutenberg_register_packages_scripts( $scripts ) {
 		$version      = isset( $asset['version'] ) ? $asset['version'] : $default_version;
 
 		// Register the runtime dependency for each entry point.
-		array_push( $dependencies, 'wp-runtime' );
+		$dependencies[] = 'wp-runtime';
 
 		// Register HMR dependencies for each entry point in development mode.
 		if ( gutenberg_is_hmr_enabled() ) {
-			array_push( $dependencies, '🔥hot' );
+			$dependencies[] = '🔥hot';
 		}
 
 		// Add dependencies that cannot be detected and generated by build tools.

diff --git a/tools/webpack/packages.js b/tools/webpack/packages.js
@@ -202,7 +202,7 @@ if ( baseConfig.mode === 'development' ) {
 		liveReload: false,
 		devMiddleware: {
 			writeToDisk( filePath ) {
-				return ! /\.hot-update\.js(on)?$/.test( filePath );
+				return ! /\.hot-update\.js(on)?(\.map)?$/.test( filePath );
 			},
 		},
 		headers: {