Ignore stylesheet imports when linting for side effects

WordPress · Apr 30, 2019 · 9eea50b · 9eea50b
1 parent 6a56dda
commit 9eea50b
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/eslint-plugin/rules/package-side-effects.js b/packages/eslint-plugin/rules/package-side-effects.js
@@ -33,10 +33,16 @@ module.exports = {
 
 		return {
 			ImportDeclaration( node ) {
+				// Only lint imports that don't specify variable names.
 				if ( node.specifiers && node.specifiers.length ) {
 					return;
 				}
 
+				// Ignore stylesheet imports.
+				if ( /\.scss$/.test( node.source.value ) ) {
+					return;
+				}
+
 				context.report(
 					node,
 					`Import of module may introduce package level side-effects. Consider adding '${ relativeFilePath }' to the package's package.json sideEffect property.`