Properly check if value is a URL

WordPress · Aug 29, 2024 · 8acbdcc · 8acbdcc
1 parent ec882b8
commit 8acbdcc
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/packages/block-editor/src/hooks/use-bindings-attributes.js b/packages/block-editor/src/hooks/use-bindings-attributes.js
@@ -10,6 +10,7 @@ import { addFilter } from '@wordpress/hooks';
 /**
  * Internal dependencies
  */
+import isURLLike from '../components/link-control/is-url-like';
 import { unlock } from '../lock-unlock';
 import BlockContext from '../components/block-context';
 
@@ -176,14 +177,12 @@ export const withBlockBindingSupport = createHigherOrderComponent(
 					for ( const [ attributeName, value ] of Object.entries(
 						values
 					) ) {
-						if ( attributeName === 'url' ) {
+						if (
+							attributeName === 'url' &&
+							( ! value || ! isURLLike( value ) )
+						) {
 							// Return null if value is not a valid URL.
-							try {
-								new URL( value );
-								attributes[ attributeName ] = value;
-							} catch ( error ) {
-								attributes[ attributeName ] = null;
-							}
+							attributes[ attributeName ] = null;
 						} else {
 							attributes[ attributeName ] = value;
 						}