proxied getEditorSettings in block-editor (#15807)

* proxied getEditorSettings in block-editor * just do what Riad says * correct getSettings * added to the readme the new property in code editor default settings * docs auto generated
WordPress · May 24, 2019 · 636b7bf · 636b7bf
1 parent 5b1addd
commit 636b7bf
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/packages/block-editor/README.md b/packages/block-editor/README.md
@@ -369,6 +369,7 @@ The default editor settings
  isRTL                         boolean       Whether the editor is in RTL mode
  bodyPlaceholder               string        Empty post placeholder
  titlePlaceholder              string        Empty title placeholder
+ codeEditingEnabled            string        Whether or not the user can switch to the code editor
 
 <a name="SkipToSelectedBlock" href="#SkipToSelectedBlock">#</a> **SkipToSelectedBlock**
 

diff --git a/packages/block-editor/src/components/block-settings-menu/block-mode-toggle.js b/packages/block-editor/src/components/block-settings-menu/block-mode-toggle.js
@@ -34,9 +34,9 @@ export function BlockModeToggle( { blockType, mode, onToggleMode, small = false,
 
 export default compose( [
 	withSelect( ( select, { clientId } ) => {
-		const { getBlock, getBlockMode } = select( 'core/block-editor' );
+		const { getBlock, getBlockMode, getSettings } = select( 'core/block-editor' );
 		const block = getBlock( clientId );
-		const isCodeEditingEnabled = select( 'core/editor' ).getEditorSettings().codeEditingEnabled;
+		const isCodeEditingEnabled = getSettings().codeEditingEnabled;
 
 		return {
 			mode: getBlockMode( clientId ),

diff --git a/packages/block-editor/src/store/defaults.js b/packages/block-editor/src/store/defaults.js
@@ -26,6 +26,7 @@ export const PREFERENCES_DEFAULTS = {
  *  isRTL                         boolean       Whether the editor is in RTL mode
  *  bodyPlaceholder               string        Empty post placeholder
  *  titlePlaceholder              string        Empty title placeholder
+ *  codeEditingEnabled            string        Whether or not the user can switch to the code editor
  */
 export const SETTINGS_DEFAULTS = {
 	alignWide: false,

diff --git a/packages/editor/src/components/provider/index.js b/packages/editor/src/components/provider/index.js
@@ -78,6 +78,7 @@ class EditorProvider extends Component {
 				'allowedBlockTypes',
 				'availableLegacyWidgets',
 				'bodyPlaceholder',
+				'codeEditingEnabled',
 				'colors',
 				'disableCustomColors',
 				'disableCustomFontSizes',