Use config level overrides property to ignore test and benchmark fi…

…les instead of condition within rule.
WordPress · Mar 7, 2019 · 5c0045f · 5c0045f
1 parent dfe154c
commit 5c0045f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/packages/eslint-plugin/configs/custom.js b/packages/eslint-plugin/configs/custom.js
@@ -24,4 +24,10 @@ module.exports = {
 			},
 		],
 	},
+	overrides: {
+		files: [ '**/test/*.js', '**/benchmark/*.js' ],
+		rules: {
+			'@wordpress/package-side-effects': 'off',
+		},
+	},
 };
diff --git a/packages/eslint-plugin/rules/package-side-effects.js b/packages/eslint-plugin/rules/package-side-effects.js
@@ -7,13 +7,6 @@ module.exports = {
 	},
 	create( context ) {
 		const filename = context.getFilename();
-
-		// Don't lint files in the test folder (otherwise `describe` is flagged).
-		// TODO - accept a list of file or function names to ignore as a configuration option.
-		if ( filename.includes( '/test/' ) ) {
-			return {};
-		}
-
 		const { pkg: packageJson, path: packageJsonPath } = readPkgUp.sync( { cwd: filename } );
 
 		// Unable to find a package.json, so don't lint this file.

diff --git a/packages/hooks/benchmark/index.js b/packages/hooks/benchmark/index.js
@@ -1,5 +1,3 @@
-/* eslint-disable @wordpress/package-side-effects */
-
 const Benchmark = require( 'benchmark' );
 const hooks = require( '../' );
 

diff --git a/packages/i18n/benchmark/index.js b/packages/i18n/benchmark/index.js
@@ -1,5 +1,3 @@
-/* eslint-disable @wordpress/package-side-effects */
-
 const Benchmark = require( 'benchmark' );
 const { __ } = require( '../' );
 

diff --git a/packages/is-shallow-equal/test/index.js b/packages/is-shallow-equal/test/index.js
@@ -1,3 +1,5 @@
+/* eslint-disable @wordpress/package-side-effects */
+
 /**
  * Internal dependencies
  */