Skip to content

Commit

Permalink
Rename icons, primitives tsconfig to _tsconfig
Browse files Browse the repository at this point in the history
[#21613](#21613) "hid"
TypeScript emitted type declarations for `@wordpress/element` when it
was found to conflict with 3rd party type declarations on
DefinitelyTyped.

Disabling `@wordpress/element` cascaded to require disabling type
checking for `@wordpress/icons` and `@wordpress/primitives`, two
dependent packages.

The lint-staged flow is slightly different from the full
`build:package-types` script in that it attempts to do a minimal build
in the interest of speed. This flow checks for the presence of a
`tsconfig.json` file in the root of the package with changes and runs
its package build.

While removing the affected packages from the main tsconfig.json did
remove them from the primary build, changes to primitives and icons
packages will fail because they cannot find the `@wordpress/element`
types as was intended in #21613.

By renaming the package tsconfig.json files, they are excluded from the
lint-staged typechecking as well.
  • Loading branch information
sirreal committed Apr 22, 2020
1 parent d7a1f17 commit 535ca68
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 0 deletions.
File renamed without changes.
File renamed without changes.

0 comments on commit 535ca68

Please sign in to comment.