Remove duplication

packages/dataviews/src/bulk-actions-toolbar.tsx

@@ -18,7 +18,7 @@ import { useRegistry } from '@wordpress/data';
  * Internal dependencies
  */
 import { ActionWithModal } from './item-actions';
-import type { Action, AnyItem } from './types';
+import type { Action, AnyItem, setSelection } from './types';
 import type { ActionTriggerProps } from './item-actions';
 
 interface ActionButtonProps< Item extends AnyItem > {
@@ -32,18 +32,14 @@ interface ToolbarContentProps< Item extends AnyItem > {
 	selection: string[];
 	actionsToShow: Action< Item >[];
 	selectedItems: Item[];
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 }
 
 interface BulkActionsToolbarProps< Item extends AnyItem > {
 	data: Item[];
 	selection: string[];
 	actions: Action< Item >[];
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 	getItemId: ( item: Item ) => string;
 }
 
@@ -135,9 +131,7 @@ function renderToolbarContent< Item extends AnyItem >(
 	selectedItems: Item[],
 	actionInProgress: string | null,
 	setActionInProgress: ( actionId: string | null ) => void,
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void
+	onSelectionChange: setSelection
 ) {
 	return (
 		<>

packages/dataviews/src/bulk-actions.tsx

@@ -14,7 +14,7 @@ import { useRegistry } from '@wordpress/data';
  * Internal dependencies
  */
 import { unlock } from './lock-unlock';
-import type { Action, ActionModal, AnyItem } from './types';
+import type { Action, ActionModal, AnyItem, setSelection } from './types';
 
 const {
 	DropdownMenuV2: DropdownMenu,
@@ -46,9 +46,7 @@ interface BulkActionsProps< Item extends AnyItem > {
 	data: Item[];
 	actions: Action< Item >[];
 	selection: string[];
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 	getItemId: ( item: Item ) => string;
 }
 

packages/dataviews/src/dataviews.tsx

@@ -22,7 +22,14 @@ import { VIEW_LAYOUTS } from './layouts';
 import BulkActions from './bulk-actions';
 import { normalizeFields } from './normalize-fields';
 import BulkActionsToolbar from './bulk-actions-toolbar';
-import type { Action, AnyItem, Field, View, ViewBaseProps } from './types';
+import type {
+	Action,
+	AnyItem,
+	Field,
+	View,
+	ViewBaseProps,
+	setSelection,
+} from './types';
 
 interface DataViewsProps< Item extends AnyItem > {
 	view: View;
@@ -40,9 +47,7 @@ interface DataViewsProps< Item extends AnyItem > {
 	};
 	supportedLayouts: string[];
 	selection?: string[];
-	setSelection?: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	setSelection?: setSelection;
 	onSelectionChange?: ( items: Item[] ) => void;
 }
 

packages/dataviews/src/single-selection-checkbox.tsx

@@ -7,13 +7,11 @@ import { CheckboxControl } from '@wordpress/components';
 /**
  * Internal dependencies
  */
-import type { Field, AnyItem } from './types';
+import type { Field, AnyItem, setSelection } from './types';
 
 interface SingleSelectionCheckboxProps< Item extends AnyItem > {
 	selection: string[];
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 	item: Item;
 	getItemId: ( item: Item ) => string;
 	primaryField?: Field< Item >;

packages/dataviews/src/types.ts

@@ -3,6 +3,10 @@
  */
 import type { ReactElement, ReactNode } from 'react';
 
+export type setSelection = (
+	selection: string[] | ( ( prevState: string[] ) => string[] )
+) => void;
+
 export type SortDirection = 'asc' | 'desc';
 
 /**
@@ -376,9 +380,7 @@ export interface ViewBaseProps< Item extends AnyItem > {
 	getItemId: ( item: Item ) => string;
 	isLoading?: boolean;
 	onChangeView( view: View ): void;
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 	selection: string[];
 	setOpenedFilter: ( fieldId: string ) => void;
 	view: View;

packages/dataviews/src/view-grid.tsx

@@ -22,14 +22,18 @@ import { __ } from '@wordpress/i18n';
 import ItemActions from './item-actions';
 import SingleSelectionCheckbox from './single-selection-checkbox';
 import { useHasAPossibleBulkAction } from './bulk-actions';
-import type { Action, AnyItem, NormalizedField, ViewGridProps } from './types';
+import type {
+	Action,
+	AnyItem,
+	NormalizedField,
+	ViewGridProps,
+	setSelection,
+} from './types';
 
 interface GridItemProps< Item extends AnyItem > {
 	selection: string[];
 	data: Item[];
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 	getItemId: ( item: Item ) => string;
 	item: Item;
 	actions: Action< Item >[];

packages/dataviews/src/view-table.tsx

@@ -51,6 +51,7 @@ import type {
 	SortDirection,
 	ViewTable as ViewTableType,
 	ViewTableProps,
+	setSelection,
 } from './types';
 
 const {
@@ -72,9 +73,7 @@ interface HeaderMenuProps< Item extends AnyItem > {
 
 interface BulkSelectionCheckboxProps< Item extends AnyItem > {
 	selection: string[];
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 	data: Item[];
 	actions: Action< Item >[];
 	getItemId: ( item: Item ) => string;
@@ -89,9 +88,7 @@ interface TableRowProps< Item extends AnyItem > {
 	primaryField?: NormalizedField< Item >;
 	selection: string[];
 	getItemId: ( item: Item ) => string;
-	onSelectionChange: (
-		selection: string[] | ( ( prevState: string[] ) => string[] )
-	) => void;
+	onSelectionChange: setSelection;
 	data: Item[];
 }