Skip to content

Commit

Permalink
Disable inconsistent gallery end-to-end test (#22726)
Browse files Browse the repository at this point in the history
* Disable flakey gallery test

* Remove non-functioning media modal exceptions
  • Loading branch information
talldan authored May 29, 2020
1 parent e8e75f0 commit 2181823
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
4 changes: 0 additions & 4 deletions packages/e2e-tests/config/setup-test-framework.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,6 @@ async function runAxeTestsForBlockEditor() {
'.edit-post-layout__metaboxes',
// Ignores elements created by TinyMCE.
'.mce-container',
// Ignores elements within the media modal.
// Related: https://core.trac.wordpress.org/ticket/50273
'.media-modal',
'.media-modal .attachment',
// These properties were not included in the 1.1 spec
// through error, they should be allowed on role="row":
// https://github.com/w3c/aria/issues/558
Expand Down
13 changes: 12 additions & 1 deletion packages/e2e-tests/specs/editor/blocks/gallery.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,18 @@ describe( 'Gallery', () => {
expect( await getEditedPostContent() ).toMatch( regex );
} );

it( 'when initially added the media library shows the Create Gallery view', async () => {
// Disable reason:
// This test would be good to enable, but the media modal contains an
// invalid role, which is causing Axe tests to fail:
// https://core.trac.wordpress.org/ticket/50273
//
// Attempts to add an Axe exception for the media modal haven't proved
// successful:
// https://github.com/WordPress/gutenberg/pull/22719
//
// This test could be re-enabled once the trac ticket is solved.
// eslint-disable-next-line jest/no-disabled-tests
it.skip( 'when initially added the media library shows the Create Gallery view', async () => {
await insertBlock( 'Gallery' );
await clickButton( 'Media Library' );
await page.waitForSelector( '.media-frame' );
Expand Down

0 comments on commit 2181823

Please sign in to comment.