-
Notifications
You must be signed in to change notification settings - Fork 33
Docs rework in preparation for WP 6.9 #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Moved all PHP related docs to the php-api.md Created new README.md file with correct doc ordering Removed doc file numbering Updating main repo README.md doc links
Adding reference for abilities_api_init Moving hook registration in code examples above callback function for better readability
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #117 +/- ##
=========================================
Coverage 90.59% 90.59%
Complexity 177 177
=========================================
Files 20 20
Lines 1489 1489
Branches 116 117 +1
=========================================
Hits 1349 1349
Misses 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Adding ability_class information and example
|
Added ability_class example |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structural changes look great to me.
Thank you also for covering the missing WP filter for Abilities API init.
What has changed for PHP documentation? You consolidated two files. What else should I pay attention to so I don’t have every line again? 😀
Major changes were the addition of the category function related documentation, and the inclusion of the |
|
Review: #95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included a few clarifications for the latest changes to improve correctness. Let’s include them. Overall this looks great. Thank you for all improvements. Documentation looks pretty good at this stage 👏🎉
|
I see that recent addition for category handling on the client might require some additional work to land it. Let us know if you need additional pass for review. |
WIP PR to work on doc updates needed for 6.9 merge proposal
Fixes #110
Fixes #111
Fixes #113
Still need to implement: #111 (comment)