GH Actions: update for the release of PHP 8.3 #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... which is expected later today. * Builds against PHP 8.3 are no longer allowed to fail. * Add _allowed to fail_ build against PHP 8.4.
|
Note: the branch protection settings will need an update for this PR. |
GaryJones
approved these changes
Nov 23, 2023
dingo-d
approved these changes
Nov 23, 2023
@jrfnl did you remove the branch protection? Because I can merge the PR 🤷🏼♂️ Or is it because we're maintainers? |
I had not, but I have now. It wasn't that the PR would be blocked, but we'd want to block future PRs if builds against PHP 8.3 don't pass, so I've added the two 8.3 builds to the required checks now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which is expected later today.