Add New "WordPress.PHP.DiscourageGoto" sniff to Extra
#1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of goto is seen as a typical code smell. Includes unit tests. Adding this sniff to `Extra` for now. The sniff can be moved to `Core` once the handbook has been adjusted (if it will be). This sniff is a duplicate of the same as pulled upstream in PR squizlabs/PHP_CodeSniffer 1664 Once the minimum PHPCS requirement for WPCS goes up beyond the version in which the upstream PR is merged, this sniff can be safely removed.
jrfnl
changed the title
ExtraExtra
23 tasks
westonruter
approved these changes
Sep 19, 2017
GaryJones
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of
gotois seen as a typical code smell.This sniff is a duplicate of the same as pulled upstream in PR squizlabs/PHP_CodeSniffer#1664
Once the minimum PHPCS requirement for WPCS goes up beyond the version in which the upstream PR is merged, this sniff can be safely removed.
The fact that this is a duplicate with an upstream sniff is also the reason why the sniff itself throws a
warningwhich is changed to anerrorvia the ruleset.Includes unit tests.
Adding this sniff to
Extrafor now. The sniff can be moved toCoreonce the handbook has been adjusted (if it will be).Fixes #1149