Fix tests for expired and revoked SSL certificates#967
Merged
Conversation
schlessera
force-pushed
the
fix/certificate-expiration-revocation-checking
branch
3 times, most recently
from
ad7d157 to
98571f6
Compare
The tests for expired or revoked SSL certificates were failing for both Curl and FsockOpen because the test site we had been using has changed (https://testssl-expire.disig.sk/index.en.html). This commit switches the test site to use expired/revoked.badssl.com, which is more of an industry standard. The exception message to expect needed to be changed as well to make the expired test pass. The revoked test has been set to be skipped, as it turns out that revocation checking is disabled by default for PHP's cURL. See #966
schlessera
force-pushed
the
fix/certificate-expiration-revocation-checking
branch
from
98571f6 to
17cc142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for expired or revoked SSL certificates were failing for both Curl and FsockOpen because the test site we had been using has changed (https://testssl-expire.disig.sk/index.en.html).
This PR switches the test site to use expired/revoked.badssl.com, which is more of an industry standard.
The exception message to expect needed to be changed as well to make the expired test pass.
The revoked test has been set to be skipped, as it turns out that revocation checking is disabled by default for PHP's cURL.
See #966