Update schema-type-printer to output "never" for omitted GraphQL types (

keystonejs#8355) Co-authored-by: Josh Calder <josh@opensaas.com.au>
WooRung · Mar 2, 2023 · ce600cf · ce600cf
1 parent c3ce0da
commit ce600cf
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/.changeset/lemon-cougars-peel.md b/.changeset/lemon-cougars-peel.md
@@ -0,0 +1,5 @@
+---
+'@keystone-6/core': patch
+---
+
+Fixes schema type printer to output `never` for omitted types.
diff --git a/packages/core/src/lib/schema-type-printer.tsx b/packages/core/src/lib/schema-type-printer.tsx
@@ -196,21 +196,13 @@ function printListTypeInfo<L extends InitialisedList>(
     `    inputs: {`,
     `      where: ${whereInputName};`,
     `      uniqueWhere: ${whereUniqueInputName};`,
-    ...(list.graphql.isEnabled.create ? [
-    `      create: ${createInputName};`,
-    ] : []),
-    ...(list.graphql.isEnabled.update ? [
-    `      update: ${updateInputName};`,
-    ] : []),
+    `      create: ${list.graphql.isEnabled.create ? createInputName : 'never'};`,
+    `      update: ${list.graphql.isEnabled.update ? updateInputName : 'never'};`,
     `      orderBy: ${listOrderName};`,
     `    };`,
     `    prisma: {`,
-    ...(list.graphql.isEnabled.create ? [
-    `      create: Resolved${createInputName}`,
-    ] : []),
-    ...(list.graphql.isEnabled.update ? [
-    `      update: Resolved${updateInputName}`,
-    ] : []),
+    `      create: ${list.graphql.isEnabled.create ? `Resolved${createInputName}` : 'never'};`,
+    `      update: ${list.graphql.isEnabled.update ? `Resolved${updateInputName}` : 'never'};`,
     `    };`,
     `    all: __TypeInfo;`,
     `  };`,

diff --git a/packages/core/src/scripts/tests/__snapshots__/artifacts.test.ts.snap b/packages/core/src/scripts/tests/__snapshots__/artifacts.test.ts.snap
@@ -142,8 +142,8 @@ export declare namespace Lists {
         orderBy: TodoOrderByInput;
       };
       prisma: {
-        create: ResolvedTodoCreateInput
-        update: ResolvedTodoUpdateInput
+        create: ResolvedTodoCreateInput;
+        update: ResolvedTodoUpdateInput;
       };
       all: __TypeInfo;
     };