-
Notifications
You must be signed in to change notification settings - Fork 143
Multilingual Content (PoC) #6282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Cyperghost
wants to merge
20
commits into
6.2
Choose a base branch
from
6.2-multilingual-content-v2
base: 6.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtdesign
requested changes
May 8, 2025
wcfsetup/install/files/lib/system/user/rank/command/SaveContent.class.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
dtdesign
approved these changes
May 8, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6109
TODO
Performance tests
Different queries were tested, these have different performance with larger tables.
LATERAL
is currently not available in MariaDB and has also shown poor performance in MySQL and was therefore not investigated further.An
UNION
query returned a slightly worse result thanROW_NUMBER
and was not investigated further.The best results were achieved with simple subqueries on the content table
wcf1_test_content
.Test Table
Queries only sorted by title
Query with simple subqueries
Output
JOIN on
ROW_NUMBER
Output
Query with Subquery and JOIN
Output
Queries with sort and filter by title
Query with simple subqueries
Output
JOIN on
ROW_NUMBER
Output
Query with Subquery and JOIN
Output
MariaDB delivers very similar results to the queries.