Replace the label chooser with a new LabelPicker#5684
Draft
Conversation
The naming is more in line with the PHP API and makes it clear that this is not the label group’s id.
The previous implementation required a lot of boilerplate code that was copied a lot of times.
TimWolla
reviewed
Oct 9, 2023
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
I did a first pass through the PR, but did not yet look into all the files.
wcfsetup/install/files/lib/system/label/LabelPickerGroup.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/label/LabelPickerGroup.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/label/LabelPickerGroup.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/data/article/category/ArticleCategory.class.php
Outdated
Show resolved
Hide resolved
TimWolla
reviewed
Oct 13, 2023
wcfsetup/install/files/lib/system/label/LabelPickerGroup.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/form/builder/field/label/LabelFormField.class.php
Show resolved
Hide resolved
TimWolla
reviewed
Oct 13, 2023
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
I don't have any further remarks.
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing label selection uses a legacy jQuery component and requires a lot of boilerplate code to integrate with both the frontend and backend. The new
LabelPickerandLabelPickerGroupimplementation is designed to simplify the API usage and to provide a “drop-in replacement” for existing usages.The selection of a label is now backed by the
<woltlab-core-label-picker>web component that autonomously handles state changes and is eagerly evaluated. The later allows the component to render the proper initial state without requiring an extra render pass, removing the visible state change on page load when a value was preselected.This PR is the foundation for the introduction of multiple label picks per label group and is intended to provide an API that is transparent to the implementers regardless of the use of single or multiple selections.
See https://www.woltlab.com/community/thread/288676-mehrere-labels-aus-selber-labelgruppe/