Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SQLITE_ENABLE_DBSTAT_VTAB #1228

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

mikeburgh
Copy link
Contributor

This enables the virtual stats table in SQLite https://www.sqlite.org/dbstat.html

Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! First time I’ve seen this feature. Is there any performance penalty to enabling this?

@mikeburgh
Copy link
Contributor Author

Not that I have witnessed, and a bit of digging through the forums turned up this:

"SQLITE_ENABLE_DBSTAT_VTAB enables the dbstat virtual table. This will make the executable bigger, but should not impact performance if it is not used."

@rvion
Copy link

rvion commented Aug 4, 2024

It is usually activated in other builds I know of.

I would love better-sqlite3 to have it cause I really need it🙏

@rvion
Copy link

rvion commented Aug 4, 2024

adding an example use-case to motivate the merge:

Many apps will allow people to store custom json or binary blobs in their DB => many users may by mistake blow up their DB size by doing something wrong => many devs will want a quick way to see if table size (count and size) make sense.

image

@mceachen
Copy link
Member

mceachen commented Aug 4, 2024

@JoshuaWise could you check this out please?

@JoshuaWise JoshuaWise merged commit 31e0e0c into WiseLibs:master Aug 15, 2024
17 checks passed
@rvion
Copy link

rvion commented Aug 15, 2024

Thanks 🔥

johannes-vogel referenced this pull request in cap-js/cds-dbs Aug 21, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [better-sqlite3](https://togithub.com/WiseLibs/better-sqlite3) |
[`11.1.2` ->
`11.2.0`](https://renovatebot.com/diffs/npm/better-sqlite3/11.1.2/11.2.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/better-sqlite3/11.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/better-sqlite3/11.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/better-sqlite3/11.1.2/11.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/better-sqlite3/11.1.2/11.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>WiseLibs/better-sqlite3 (better-sqlite3)</summary>

###
[`v11.2.0`](https://togithub.com/WiseLibs/better-sqlite3/releases/tag/v11.2.0)

[Compare
Source](https://togithub.com/WiseLibs/better-sqlite3/compare/v11.1.2...v11.2.0)

#### What's Changed

- Support builds for Electron v32 by
[@&#8203;neoxpert](https://togithub.com/neoxpert) in
[https://github.com/WiseLibs/better-sqlite3/pull/1226](https://togithub.com/WiseLibs/better-sqlite3/pull/1226)
- Adding SQLITE_ENABLE_DBSTAT_VTAB by
[@&#8203;mikeburgh](https://togithub.com/mikeburgh) in
[https://github.com/WiseLibs/better-sqlite3/pull/1228](https://togithub.com/WiseLibs/better-sqlite3/pull/1228)

#### New Contributors

- [@&#8203;mikeburgh](https://togithub.com/mikeburgh) made their first
contribution in
[https://github.com/WiseLibs/better-sqlite3/pull/1228](https://togithub.com/WiseLibs/better-sqlite3/pull/1228)

**Full Changelog**:
WiseLibs/better-sqlite3@v11.1.2...v11.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/cap-js/cds-dbs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants