Fix python setuptools on macOS #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaWise
approved these changes
Apr 29, 2024
patricebender
referenced
this pull request
in cap-js/cds-dbs
May 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [better-sqlite3](https://togithub.com/WiseLibs/better-sqlite3) | [`^9.3.0` -> `^10.0.0`](https://renovatebot.com/diffs/npm/better-sqlite3/9.6.0/10.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>WiseLibs/better-sqlite3 (better-sqlite3)</summary> ### [`v10.0.0`](https://togithub.com/WiseLibs/better-sqlite3/releases/tag/v10.0.0) [Compare Source](https://togithub.com/WiseLibs/better-sqlite3/compare/v9.6.0...v10.0.0) #### What's Changed - Update troubleshooting.md by [@​mceachen](https://togithub.com/mceachen) in [https://github.com/WiseLibs/better-sqlite3/pull/1178](https://togithub.com/WiseLibs/better-sqlite3/pull/1178) - Fix python setuptools on macOS by [@​mceachen](https://togithub.com/mceachen) in [https://github.com/WiseLibs/better-sqlite3/pull/1181](https://togithub.com/WiseLibs/better-sqlite3/pull/1181) - Add Node.js v22. Drop ancient EOL versions of Node.js and Electron by [@​mceachen](https://togithub.com/mceachen) in [https://github.com/WiseLibs/better-sqlite3/pull/1182](https://togithub.com/WiseLibs/better-sqlite3/pull/1182) **Full Changelog**: WiseLibs/better-sqlite3@v9.6.0...v10.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cap-js/cds-dbs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
abhaybuch
pushed a commit
to felixrieseberg/better-sqlite3
that referenced
this pull request
Jun 18, 2024
fix macos setuptools workaround
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JoshuaWise this should fix the current build failure on
master.Fixes https://github.com/WiseLibs/better-sqlite3/actions/runs/8853339888/job/24313966887
ifclauses didn't capturemacos-latestandmacos-14properlybrew install python-setuptoolsinstead of--break-system-packages.NOTE: it'd be ideal if we could extract this as a setup task to eliminate the code duplication here, but I didn't want to make the diff bigger. Holler if you'd prefer that.