Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support builds for Electron v29 #1151

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

neoxpert
Copy link
Contributor

This branch adds some adjustments in order to enable builds for Electron v29. The signature of SetAccessor has been adjusted to be the same as before for all versions below 29. For 29 and up the new function signature will be used.

@mceachen
Copy link
Member

mceachen commented Mar 4, 2024

Thanks for the PR, @neoxpert !

@JoshuaWise can you take a look at this please?

(I don't have merge permissions for this PR)

@veemex
Copy link

veemex commented Mar 11, 2024

First of all good job guys! When do you think this can be merged ? I am currently using the branch from @neoxpert , it seems it works for me.

@ReconVirus
Copy link

Holy shit this works as ive been having trouble with it for weeks. Hella mad props to @neoxpert for the branch. A simple install
npm install neoxpert/better-sqlite3#fix_electron29_build electron-rebuild fucking works no problem now, things just fucking works now thank you so much

@JoshuaWise this is it!

@JoshuaWise JoshuaWise merged commit e28e04a into WiseLibs:master Apr 3, 2024
14 checks passed
@JoshuaWise
Copy link
Member

Sorry for the delay on this one. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants