-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support builds for Electron v29 #1151
Conversation
Thanks for the PR, @neoxpert ! @JoshuaWise can you take a look at this please? (I don't have merge permissions for this PR) |
First of all good job guys! When do you think this can be merged ? I am currently using the branch from @neoxpert , it seems it works for me. |
Holy shit this works as ive been having trouble with it for weeks. Hella mad props to @neoxpert for the branch. A simple install @JoshuaWise this is it! |
Sorry for the delay on this one. Thanks for the contribution! |
This branch adds some adjustments in order to enable builds for Electron v29. The signature of
SetAccessor
has been adjusted to be the same as before for all versions below 29. For 29 and up the new function signature will be used.