-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for electron v29
prebuilds
#1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻
Yup. The same error I mentioned in the note. Needs some work it seems. I wonder if it's time to switch to N-API. |
(I totally missed your comment -- I just looked at the diff and LGTM'ed it in) |
@JoshuaWise #1127 seems like it may solve this if those default params are indeed optional. |
Oops. That was my guess when you did the release. |
@m4heshd please submit a PR that reverts this, and I'll do another patch-release to roll back. @JoshuaWise alternatively, you can just roll back the last release: Sorry I didn't catch your comment! |
No worries. Sent the PR. |
Stable electron v29 just released. Prebuilds were tested here but the tests are failing with the following error.
Pinging @JoshuaWise.