Add ability to get to app settings in AndroidTV #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
requested changes
Oct 12, 2020
Signed-off-by: Adam Irr <adam.irr@outlook.com>
|
Merged as e802e53, thanks! |
|
Reverted. Settings and log and such do not work with the dpad very well. If you want some particular part of the settings in the TV app, figure out a minimal way of representing it there. |
|
It is finicky but using the FireTV app (which lets you paste strings), I was able to simply paste the keys and configure everything. Yes it got hung up a few times but some repeated dpad presses got around it. Now that the tunnel is up, there is no way to enter the properties of the tunnel to change settings (such as with the context button, long press, or even secondary button). having something finicky where I can get to the tunnel settings and modify applications, for example, or IP range, is better than nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a button to get to the existing settings menu from Android TV.
I have tested this on the Android TV emulator and was able to view the app logs.