forked from brettviren/wire-cell-toolkit
-
Notifications
You must be signed in to change notification settings - Fork 24
Porting: multi-plane, Steiner, traj. fitting #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HaiwangYu
wants to merge
579
commits into
master
Choose a base branch
from
apply-pointcloud
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will produce fresh slices from ROOT data and these slices are in general a superset of the union of all slices as slices from blob-free time slices will be included. The activity map for a fresh slice is made directly from ROOT data and does not include any "bodge" for 2-plane views as done in the upstream UbooneBlobSource's. Activity in a dead channel/slice are still marked with the conventional (0, 1e2) signal measure and unsertainty. This also changes the API for add_ctpc() and add_dead_winds() helper functions to be more straightforward taking a vector of ISlice instead of a vector of IBlobSet, just to get a slice from each blob set.
…kit into apply-pointcloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.