This repository was archived by the owner on Apr 7, 2024. It is now read-only.
Iti 0/feature/sigmasms #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-0/feature/sigmasms
…-0/feature/sigmasms
|
Than you for opening your PR! Reference to the YouTrack issue: ITI-0 |
cl-bvl
reviewed
Jan 10, 2022
config/notifiers.go
Outdated
| @@ -457,6 +457,7 @@ type SigmaConfig struct { | |||
| URL *URL `yaml:"url" json:"url"` | |||
| APIKey Secret `yaml:"api_key" json:"api_key"` | |||
| Recipient []string `yaml:"recipient" json:"recipient"` | |||
| RecipientExclude []string `yaml:"recipient_exclude" json:"recipient_exclude"` | |||
There was a problem hiding this comment.
Я бы убрал RecipientExclude из конфига:
- Он может путать, т.к. для SMS этот параметр никак не обрабатывается.
- Не очень представляю кейс, когда он нужен. Если мы добавили телефон в конфиг, то мы не захотим его исключать.
There was a problem hiding this comment.
Этот параметр связан с использованием групп, если в перспективе мы захотим ими пользоваться.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил голосовые уведомления