Hotfix for type check of primitive data types

WilliamYuhangLee · Apr 5, 2019 · f77066d · f77066d
1 parent 90ea08d
commit f77066d
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 13 deletions.
diff --git a/prototype.creep.js b/prototype.creep.js
@@ -54,7 +54,7 @@ module.exports = function () {
                 Object.assign(opts, second);
             }
             return oldMoveTo.apply(this, [first, opts]);
-        } else if (first instanceof Number && second instanceof Number) {
+        } else if (typeof first === "number" && typeof second === "number") {
             if (third instanceof Object) {
                 Object.assign(opts, third);
             }

diff --git a/prototype.spawn.js b/prototype.spawn.js
@@ -1,9 +1,9 @@
 /**
  * Spawn a creep of the given role at this spawn.
  *
- * @param {String} roleName: the name of the creep's role
+ * @param {string} roleName: the name of the creep's role
  * @param {Object} [opts] an Object with additional options for the spawning process
- * @param {String} [opts] a String parameter that serves specific purposes for each role
+ * @param {string} [opts] a string parameter that serves specific purposes for each role
  *
  * @returns {Number} the result of the spawning process
  */

diff --git a/role.builder.js b/role.builder.js
@@ -38,7 +38,7 @@ function run(creep) {
 /**
  * Clear out the creep's storage from Memory
  *
- * @param {String} creepName
+ * @param {string} creepName
  */
 function clear(creepName) {
     delete Memory.creeps[creepName];

diff --git a/role.claimer.js b/role.claimer.js
@@ -6,7 +6,7 @@ const roleName = "claimer";
  *
  * @param {StructureSpawn} spawn: where the new creep is spawned
  * @param {Object} [opts] an Object with additional options for the spawning process
- * @param {String} [opts] the name of target room or flag
+ * @param {string} [opts] the name of target room or flag
  */
 function spawn(spawn, opts) {
     let args = {
@@ -18,7 +18,7 @@ function spawn(spawn, opts) {
     if (opts) {
         if (opts instanceof Object) {
             _.merge(args, opts);
-        } else if (opts instanceof String && (Game.map.isRoomAvailable(opts) || Game.flags[opts])) {
+        } else if (typeof opts === "string" && (Game.map.isRoomAvailable(opts) || Game.flags[opts])) {
             args.memory.target = opts;
         } else {
             return ERR_INVALID_ARGS;
@@ -69,7 +69,7 @@ function run(creep) {
 /**
  * Clear out the creep's storage from Memory
  *
- * @param {String} creepName
+ * @param {string} creepName
  */
 function clear(creepName) {
     delete Memory.creeps[creepName];

diff --git a/role.collector.js b/role.collector.js
@@ -119,7 +119,7 @@ function run(creep) {
 /**
  * Clear out the creep's storage from Memory
  *
- * @param {String} creepName
+ * @param {string} creepName
  */
 function clear(creepName) {
     let targetID = Memory.creeps[creepName].targetID;

diff --git a/role.harvester.js b/role.harvester.js
@@ -5,6 +5,7 @@ const roleName = "harvester";
  * Spawn a creep as a harvester from the designated spawn.
  *
  * @param {StructureSpawn} spawn
+ * @param {string} homeName: name of the new creep's home Room
  */
 function spawn(spawn) {
     return spawn.spawnCreep(body, modules.util.genName(roleName), { memory: { role: roleName }});
@@ -40,7 +41,7 @@ function run(creep) {
 /**
  * Clear out the creep's storage from Memory
  *
- * @param {String} creepName
+ * @param {string} creepName
  */
 function clear(creepName) {
     delete Memory.creeps[creepName];

diff --git a/role.repairer.js b/role.repairer.js
@@ -40,7 +40,7 @@ function run(creep) {
 /**
  * Clear out the creep's storage from Memory
  *
- * @param {String} creepName
+ * @param {string} creepName
  */
 function clear(creepName) {
     delete Memory.creeps[creepName];

diff --git a/role.upgrader.js b/role.upgrader.js
@@ -6,7 +6,7 @@ const roleName = "upgrader";
  *
  * @param {StructureSpawn} spawn
  * @param {Object} [opts] an Object with additional options for the spawning process
- * @param {String} [opts] the name of the new creep's home Room
+ * @param {string} [opts] the name of the new creep's home Room
  */
 function spawn(spawn, opts) {
     let args = {
@@ -18,7 +18,7 @@ function spawn(spawn, opts) {
     if (opts) {
         if (opts instanceof Object) {
             _.merge(args, opts);
-        } else if (opts instanceof String && Game.map.isRoomAvailable(opts)) {
+        } else if (typeof opts === "string" && Game.map.isRoomAvailable(opts)) {
             args.memory.home = opts;
         } else {
             return ERR_INVALID_ARGS;
@@ -57,7 +57,7 @@ function run(creep) {
 /**
  * Clear out the creep's storage from Memory
  *
- * @param {String} creepName
+ * @param {string} creepName
  */
 function clear(creepName) {
     delete Memory.creeps[creepName];