Repository navigation
perf(web): R.3 — the board stops waiting its turn - #317
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Willi363363
force-pushed
the
perf/home-history-limit
branch
from
September 18, 2026 11:33
3d45c6f to
63f1462
Compare
Willi363363
force-pushed
the
perf/home-board-in-parallel
branch
from
September 18, 2026 11:33
8e09d6c to
7a2d30e
Compare
`readBoard` was awaited on its own line, and only then did `readHome` open the
`Promise.all` below it. Nothing in that group fed the board and the board fed
none of them: same `viewerId`, same clock. The guest path had it twice over —
the day's tile waited behind the board and needs nothing from it.
**On this machine the change does not measure.** 40 runs of the guest home
against a local Postgres gave 4.45 ms before and 4.81 ms after: inside the
noise, a loopback round trip being smaller than the variance. Recorded that
way rather than dressed up.
What does measure is the depth of the waterfall, with 25 ms injected per read —
roughly a Neon round trip from a Vercel function:
signed in 50.8 ms → 25.8 ms
guest 50.6 ms → 25.4 ms
Exactly one round trip, on both paths.
The test asserts the structure and not a timing: every read a home needs is in
flight before any of them has answered. Both cases fail against the old shape.
A promise created before a branch is what track Q spent five steps on, so two
more cases say a failing board is a rejected `readHome` on both paths rather
than an unhandled rejection. Probed by floating it on purpose: the suite then
reports `9 passed, 1 error` and the job fails with no failing case — which is
`10-test-debt.md`'s own entry about Vitest, arriving from the other side.
`turbo run test --force --concurrency=1`: 10 of 10 tasks, 3 872 passed, 0
skipped. Typecheck and lint green over all 22 tasks.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DsMRxyowr2Ch5RwiAa3t9z
Willi363363
force-pushed
the
perf/home-history-limit
branch
from
September 18, 2026 11:48
63f1462 to
ceeb121
Compare
Willi363363
force-pushed
the
perf/home-board-in-parallel
branch
from
September 18, 2026 11:48
7a2d30e to
7c2d711
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third step of track R, carrying its own
R.3 ⬜ → ✅tick. Based on #316,not on
staging: both steps edit thesame twenty lines of
readHome, and resolving that in GitHub's interface is theone thing
method/01-git-flow.mdforbids. Rebased ontostagingand retargetedas soon as #316 merges.
readBoardwas awaited on its own line, and only then didreadHomeopen thePromise.allbelow it. Nothing in that group fed the board and the board fednone of them — same
viewerId, same clock. The guest path had it twice over:the day's tile waited behind the board and needs nothing from it either.
The measurement, including the one that says nothing
On this machine the change does not measure. 40 runs of the guest home
against a local Postgres:
Inside the noise — a loopback round trip is smaller than the variance. Recorded
that way rather than dressed up, because
09-query-debt.md's rule is that anote without a measurement is a guess, not that every measurement must flatter
the change.
What does measure is the depth of the waterfall. 25 ms injected per read,
which is roughly a Neon round trip from a Vercel function:
Exactly one round trip, on both paths. That is where this pays: not on a
developer's loopback, on the deployment the project actually runs.
The tests assert the structure, not a timing
Every read a home needs is in flight before any of them has answered — which is
the finding stated as an assertion, and does not depend on how fast anything is.
Both cases fail against the old shape.
A promise created before a branch is the shape track Q spent five steps on,
so two more cases say a failing board is a rejected
readHomeon both paths.Probed by floating it on purpose: the suite then reports
9 passed, 1 errorandthe job fails with no failing case —
10-test-debt.md's own Vitest entry,arriving from the other side.
Checks
turbo run test --force --concurrency=1: 10 of 10 tasks, 3 872 passed, 0 skipped.turbo run typecheck lint --force: 22 of 22.pnpm format:check: green.09-query-debt.mdloses its third entry, back at exactly 200 lines.🤖 Generated with Claude Code
https://claude.ai/code/session_01DsMRxyowr2Ch5RwiAa3t9z