Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
01ffd27
Pin to latest dev version of pymodbus
WillCodeForCats Aug 21, 2022
a6c4c23
Update requirements.txt
WillCodeForCats Aug 21, 2022
70154f1
Revert "Update requirements.txt"
WillCodeForCats Aug 21, 2022
ca4edb6
Update requirements.txt
WillCodeForCats Aug 21, 2022
8d3a280
Update requirements.txt
WillCodeForCats Aug 21, 2022
4c16225
Remove pymodbus.compat
WillCodeForCats Aug 21, 2022
e4bfce7
Revert "Update requirements.txt"
WillCodeForCats Aug 21, 2022
bce1052
Fix iter items
WillCodeForCats Aug 21, 2022
1193104
Merge branch 'main' into pymodbus-dev
WillCodeForCats Aug 21, 2022
8411ce3
Bump version for pre-release
WillCodeForCats Aug 21, 2022
8401258
Merge branch 'main' into pymodbus-dev
WillCodeForCats Sep 18, 2022
2ff37ab
Merge branch 'main' into pymodbus-dev
WillCodeForCats Sep 30, 2022
faab5e7
pymodbus dev5
WillCodeForCats Sep 30, 2022
54e7e73
Update requirements.txt
WillCodeForCats Oct 2, 2022
4ed8110
Update hub.py
WillCodeForCats Oct 2, 2022
09951a6
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 9, 2022
529aee5
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 12, 2022
84e67db
Bump pymodbus version
WillCodeForCats Oct 12, 2022
626328a
Update imports and args for pymodbus
WillCodeForCats Oct 12, 2022
d6e990d
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 12, 2022
9b1d0e2
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 13, 2022
4ed9e98
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 13, 2022
f066634
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 13, 2022
3110ad0
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 18, 2022
f735a91
Update hub.py
WillCodeForCats Oct 18, 2022
c121ef8
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 20, 2022
73ac328
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 23, 2022
0a81757
Merge branch 'main' into pymodbus-dev
WillCodeForCats Oct 24, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions custom_components/solaredge_modbus_multi/hub.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
from typing import Any, Dict, Optional

from homeassistant.core import HomeAssistant
from pymodbus.client.sync import ModbusTcpClient
from pymodbus.compat import iteritems
from pymodbus.client import ModbusTcpClient
from pymodbus.constants import Endian
from pymodbus.exceptions import ConnectionException, ModbusIOException
from pymodbus.payload import BinaryPayloadDecoder
Expand Down Expand Up @@ -402,7 +401,7 @@ async def shutdown(self) -> None:
def read_holding_registers(self, unit, address, count):
"""Read holding registers."""
with self._lock:
kwargs = {"unit": unit} if unit else {}
kwargs = {"slave": unit} if unit else {}
return self._client.read_holding_registers(address, count, **kwargs)


Expand Down Expand Up @@ -452,7 +451,7 @@ def init_device(self) -> None:
]
)

for name, value in iteritems(decoded_ident):
for name, value in iter(decoded_ident.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id}: "
Expand Down Expand Up @@ -499,7 +498,7 @@ def init_device(self) -> None:
]
)

for name, value in iteritems(self.decoded_common):
for name, value in iter(self.decoded_common.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id}: "
Expand Down Expand Up @@ -541,7 +540,7 @@ def init_device(self) -> None:
]
)

for name, value in iteritems(self.decoded_mmppt):
for name, value in iter(self.decoded_mmppt.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id} MMPPT: "
Expand Down Expand Up @@ -599,7 +598,7 @@ def read_modbus_data(self) -> None:
]
)

for name, value in iteritems(decoded_ident):
for name, value in iter(decoded_ident.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id}: "
Expand Down Expand Up @@ -736,7 +735,7 @@ def read_modbus_data(self) -> None:
)
self.advanced_power_control = True

for name, value in iteritems(self.decoded_model):
for name, value in iter(self.decoded_model.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id}: "
Expand Down Expand Up @@ -821,7 +820,7 @@ def init_device(self) -> None:
]
)

for name, value in iteritems(decoded_ident):
for name, value in iter(decoded_ident.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id} meter {self.meter_id}: "
Expand Down Expand Up @@ -865,7 +864,7 @@ def init_device(self) -> None:
]
)

for name, value in iteritems(self.decoded_common):
for name, value in iter(self.decoded_common.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id} meter {self.meter_id}: "
Expand Down Expand Up @@ -920,7 +919,7 @@ def read_modbus_data(self) -> None:
]
)

for name, value in iteritems(decoded_ident):
for name, value in iter(decoded_ident.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id} meter {self.meter_id}: "
Expand Down Expand Up @@ -1028,7 +1027,7 @@ def read_modbus_data(self) -> None:
]
)

for name, value in iteritems(self.decoded_model):
for name, value in iter(self.decoded_model.items()):
_LOGGER.debug(
(
f"Inverter {self.inverter_unit_id} meter {self.meter_id}: "
Expand Down Expand Up @@ -1115,7 +1114,7 @@ def init_device(self) -> None:
]
)

for name, value in iteritems(self.decoded_common):
for name, value in iter(self.decoded_common.items()):
if isinstance(value, float):
_LOGGER.debug(
(
Expand Down Expand Up @@ -1221,7 +1220,7 @@ def read_modbus_data(self) -> None:
]
)

for name, value in iteritems(self.decoded_model):
for name, value in iter(self.decoded_model.items()):
if isinstance(value, float):
_LOGGER.debug(
(
Expand Down
2 changes: 1 addition & 1 deletion custom_components/solaredge_modbus_multi/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "SolarEdge Modbus Multi Device",
"documentation": "https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki",
"issue_tracker": "https://github.com/WillCodeForCats/solaredge-modbus-multi/issues",
"requirements": ["pymodbus==2.5.3"],
"requirements": ["pymodbus==3.0.0"],
"dependencies": [],
"codeowners": ["@WillCodeForCats"],
"config_flow": true,
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
pymodbus == 2.5.3
pymodbus==3.0.0