Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version nums #366

Merged
merged 3 commits into from
Apr 3, 2024
Merged

chore: update version nums #366

merged 3 commits into from
Apr 3, 2024

Conversation

cpaniaguam
Copy link
Member

Two more places needed updating.

@cpaniaguam cpaniaguam added the enhancement New feature or request label Apr 2, 2024
@cpaniaguam cpaniaguam requested a review from tdivoll April 2, 2024 20:06
@cpaniaguam cpaniaguam self-assigned this Apr 2, 2024
@cpaniaguam cpaniaguam linked an issue Apr 2, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (0fde544) to head (27af0c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   90.64%   90.67%   +0.02%     
==========================================
  Files          29       29              
  Lines         951      954       +3     
==========================================
+ Hits          862      865       +3     
  Misses         89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Is there a way to grab the version number from the Project.toml directly so we don't have to update it in so many places.

@cpaniaguam
Copy link
Member Author

I was able to grab the version number from the Project.toml to define IFTVERSION. The updated test also checks this.

@cpaniaguam cpaniaguam requested a review from tdivoll April 3, 2024 17:13
tdivoll
tdivoll previously approved these changes Apr 3, 2024
Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and simplifies the process!

@cpaniaguam cpaniaguam merged commit 351d7a5 into main Apr 3, 2024
4 checks passed
@cpaniaguam cpaniaguam deleted the 365-update-iftversion-=-043 branch April 3, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Update IFTVERSION => 0.4.3
2 participants