Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove old readme content and reference new pipeline repo #360

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

tdivoll
Copy link
Collaborator

@tdivoll tdivoll commented Nov 30, 2023

Just some cleanup and adding a reference to the IFTPipeline in this README.

@tdivoll tdivoll self-assigned this Nov 30, 2023
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you added a reference to the pipeline repo. I included a suggestion to augment that a bit and another one regarding stuff about Pluto notebooks that we are not using.

README.md Outdated
## Fetch Data

The [`fetchdata.sh`](/scripts/fetchdata.sh) script requires the utilities [`gdal`](https://gdal.org/) and [`proj`](https://proj.org/). This repository includes a brewfile for ease of installation on MacOS. To install `gdal` and `proj` via homebrew, first [install homebrew](https://brew.sh/), then run `brew bundle install`
## Using in a Pipeline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Using in a Pipeline
## Interface for Pipeline Workflows

README.md Outdated
```
snakemake -c<NUM CORES>
```
See the related tools at `https://github.com/WilhelmusLab/ice-floe-tracker-pipeline.git` for a Julia Command-line Interface to access all the source functions and templates for using the Cylc pipeline orchestrator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See the related tools at `https://github.com/WilhelmusLab/ice-floe-tracker-pipeline.git` for a Julia Command-line Interface to access all the source functions and templates for using the Cylc pipeline orchestrator.
See related tools in the [IFTPipeline repo](https://github.com/WilhelmusLab/ice-floe-tracker-pipeline#ice-floe-tracker-pipeline) including a Julia Command-line Interface and templates that leverage the [Cylc](https://cylc.github.io/) pipeline orchestrator.

@@ -41,7 +42,6 @@ Instantiate the environment and run the tests:
(IceFloeTracker) pkg> test
```


## Notebooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using Pluto notebooks so I think this section could also be deleted.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have some Jupyter notebooks though, I added a statement just alerting users that they are available, but it would be up to the user to figure out how run a .ipynb.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce9869e) 90.73% compared to head (86484d6) 90.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          29       29           
  Lines         950      950           
=======================================
  Hits          862      862           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdivoll tdivoll added the documentation Improvements or additions to documentation label Nov 30, 2023
cpaniaguam
cpaniaguam previously approved these changes Nov 30, 2023
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but left another suggestion for your consideration.

README.md Outdated
## Fetch Data

The [`fetchdata.sh`](/scripts/fetchdata.sh) script requires the utilities [`gdal`](https://gdal.org/) and [`proj`](https://proj.org/). This repository includes a brewfile for ease of installation on MacOS. To install `gdal` and `proj` via homebrew, first [install homebrew](https://brew.sh/), then run `brew bundle install`
There are Jupyter notebooks in `IceFloeTracker.jl` that can be used as examples to access some of the image processing and tracking functions, available at `IceFloeTracker.jl/notebooks`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are Jupyter notebooks in `IceFloeTracker.jl` that can be used as examples to access some of the image processing and tracking functions, available at `IceFloeTracker.jl/notebooks`.
There are Jupyter notebooks illustrating the main image processing and tracking functions in the `/notebooks` folder.

@tdivoll
Copy link
Collaborator Author

tdivoll commented Dec 4, 2023

Minor update after approval

@tdivoll tdivoll merged commit 5033f49 into main Dec 4, 2023
4 checks passed
@tdivoll tdivoll deleted the cleanup-outdated-readme branch December 4, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants