Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hardcode pkg version number #332

Merged
merged 5 commits into from
Aug 21, 2023
Merged

feat: hardcode pkg version number #332

merged 5 commits into from
Aug 21, 2023

Conversation

cpaniaguam
Copy link
Member

@cpaniaguam cpaniaguam commented Aug 20, 2023

This approach is working well with IFTPipeline!

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (65994ce) 91.78% compared to head (1640a21) 91.84%.
Report is 1 commits behind head on main.

❗ Current head 1640a21 differs from pull request most recent head 748628e. Consider uploading reports for the commit 748628e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   91.78%   91.84%   +0.06%     
==========================================
  Files          29       29              
  Lines         876      871       -5     
==========================================
- Hits          804      800       -4     
+ Misses         72       71       -1     
Files Changed Coverage Δ
src/IceFloeTracker.jl 100.00% <ø> (+6.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing with Pkg.project().version instead of VersionNumber(0,2,0). It seems to return the version fine and updating the test worked as well. However, it tries to activate a Julia REPL and IFT when I try to commit the changes.

src/IceFloeTracker.jl Outdated Show resolved Hide resolved
test/test-misc.jl Outdated Show resolved Hide resolved
@cpaniaguam
Copy link
Member Author

I was testing with Pkg.project().version instead of VersionNumber(0,2,0). It seems to return the version fine and updating the test worked as well. However, it tries to activate a Julia REPL and IFT when I try to commit the changes.

I'll test this within IFTPipeline. Thanks!

cpaniaguam and others added 2 commits August 20, 2023 14:27
Co-authored-by: Timothy Divoll <timothy.divoll@gmail.com>
Co-authored-by: Timothy Divoll <timothy.divoll@gmail.com>
@cpaniaguam
Copy link
Member Author

I was testing with Pkg.project().version instead of VersionNumber(0,2,0). It seems to return the version fine and updating the test worked as well. However, it tries to activate a Julia REPL and IFT when I try to commit the changes.

I'll test this within IFTPipeline. Thanks!

When used within IFTPipeline it returns IFTPipeline's version :/. Going back to testing with hard-coding the version number.

@cpaniaguam
Copy link
Member Author

@tdivoll I think hard coding the version number is probably the way to go.

@cpaniaguam
Copy link
Member Author

@tdivoll I think hard coding the version number is probably the way to go.

@tdivoll Things working well within the container.

tdivoll
tdivoll previously approved these changes Aug 21, 2023
Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, it is a minor task to update when we update version numbers.

@cpaniaguam cpaniaguam merged commit cea00f2 into main Aug 21, 2023
2 checks passed
@cpaniaguam cpaniaguam deleted the feat-add-getiftversion branch August 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants